diff --git a/rules-tests/CodeQuality/Rector/MethodCall/AssertCompareToSpecificMethodRector/AssertCompareToSpecificMethodRectorTest.php b/rules-tests/CodeQuality/Rector/MethodCall/AssertCompareToSpecificMethodRector/AssertCompareToSpecificMethodRectorTest.php deleted file mode 100644 index 77c4e86d..00000000 --- a/rules-tests/CodeQuality/Rector/MethodCall/AssertCompareToSpecificMethodRector/AssertCompareToSpecificMethodRectorTest.php +++ /dev/null @@ -1,28 +0,0 @@ -doTestFile($filePath); - } - - public static function provideData(): Iterator - { - return self::yieldFilesFromDirectory(__DIR__ . '/Fixture'); - } - - public function provideConfigFilePath(): string - { - return __DIR__ . '/config/configured_rule.php'; - } -} diff --git a/rules-tests/CodeQuality/Rector/MethodCall/AssertCompareToSpecificMethodRector/Fixture/count.php.inc b/rules-tests/CodeQuality/Rector/MethodCall/AssertCompareToSpecificMethodRector/Fixture/count.php.inc deleted file mode 100644 index 69465c20..00000000 --- a/rules-tests/CodeQuality/Rector/MethodCall/AssertCompareToSpecificMethodRector/Fixture/count.php.inc +++ /dev/null @@ -1,35 +0,0 @@ -assertSame(5, count($something)); - $this->assertEquals(10, iterator_count($something)); - - $count = 92; - $this->assertNotEquals($count, sizeof($something), 'third argument'); - } -} - -?> ------ -assertCount(5, $something); - $this->assertCount(10, $something); - - $count = 92; - $this->assertNotCount($count, $something, 'third argument'); - } -} - -?> diff --git a/rules-tests/CodeQuality/Rector/MethodCall/AssertCompareToSpecificMethodRector/Fixture/fixture.php.inc b/rules-tests/CodeQuality/Rector/MethodCall/AssertCompareToSpecificMethodRector/Fixture/fixture.php.inc deleted file mode 100644 index 624c9e0f..00000000 --- a/rules-tests/CodeQuality/Rector/MethodCall/AssertCompareToSpecificMethodRector/Fixture/fixture.php.inc +++ /dev/null @@ -1,35 +0,0 @@ -assertEquals('string', $something['property']()); - $this->assertNotSame($foo[1]->result, count($this->results)); - $this->assertSame(1, $count); - $this->assertNotSame(2, $foo->count()); - $this->assertEquals($count, $foo->sizeof); - } -} - -?> ------ -assertEquals('string', $something['property']()); - $this->assertNotCount($foo[1]->result, $this->results); - $this->assertSame(1, $count); - $this->assertNotSame(2, $foo->count()); - $this->assertEquals($count, $foo->sizeof); - } -} - -?> diff --git a/rules-tests/CodeQuality/Rector/MethodCall/AssertCompareToSpecificMethodRector/Fixture/get_class.php.inc b/rules-tests/CodeQuality/Rector/MethodCall/AssertCompareToSpecificMethodRector/Fixture/get_class.php.inc deleted file mode 100644 index aafe145c..00000000 --- a/rules-tests/CodeQuality/Rector/MethodCall/AssertCompareToSpecificMethodRector/Fixture/get_class.php.inc +++ /dev/null @@ -1,33 +0,0 @@ - ------ - diff --git a/rules-tests/CodeQuality/Rector/MethodCall/AssertCompareToSpecificMethodRector/Fixture/skip_first_param.inc b/rules-tests/CodeQuality/Rector/MethodCall/AssertCompareToSpecificMethodRector/Fixture/skip_first_param.inc deleted file mode 100644 index 042b58f2..00000000 --- a/rules-tests/CodeQuality/Rector/MethodCall/AssertCompareToSpecificMethodRector/Fixture/skip_first_param.inc +++ /dev/null @@ -1,29 +0,0 @@ -assertSame(count($something), 5); - $this->assertSame(get_class($something), 'stdClass'); - } -} - -?> - ----- -assertSame(count($something), 5); - $this->assertSame(get_class($something), 'stdClass'); - } -} - -?> diff --git a/rules-tests/CodeQuality/Rector/MethodCall/AssertCompareToSpecificMethodRector/Fixture/skip_get_type.php.inc b/rules-tests/CodeQuality/Rector/MethodCall/AssertCompareToSpecificMethodRector/Fixture/skip_get_type.php.inc deleted file mode 100644 index 3efcd399..00000000 --- a/rules-tests/CodeQuality/Rector/MethodCall/AssertCompareToSpecificMethodRector/Fixture/skip_get_type.php.inc +++ /dev/null @@ -1,12 +0,0 @@ -assertNotSame('resource', gettype($value)); - } -} diff --git a/rules-tests/CodeQuality/Rector/MethodCall/AssertCompareToSpecificMethodRector/config/configured_rule.php b/rules-tests/CodeQuality/Rector/MethodCall/AssertCompareToSpecificMethodRector/config/configured_rule.php deleted file mode 100644 index fce611a5..00000000 --- a/rules-tests/CodeQuality/Rector/MethodCall/AssertCompareToSpecificMethodRector/config/configured_rule.php +++ /dev/null @@ -1,10 +0,0 @@ -rule(AssertCompareToSpecificMethodRector::class); -}; diff --git a/rules/CodeQuality/Rector/MethodCall/AssertCompareToSpecificMethodRector.php b/rules/CodeQuality/Rector/MethodCall/AssertCompareToSpecificMethodRector.php index 497e8f80..de471cf0 100644 --- a/rules/CodeQuality/Rector/MethodCall/AssertCompareToSpecificMethodRector.php +++ b/rules/CodeQuality/Rector/MethodCall/AssertCompareToSpecificMethodRector.php @@ -10,6 +10,7 @@ use PhpParser\Node\Expr\MethodCall; use PhpParser\Node\Expr\StaticCall; use PhpParser\Node\Identifier; +use Rector\Configuration\Deprecation\Contract\DeprecatedInterface; use Rector\PHPUnit\NodeAnalyzer\TestsNodeAnalyzer; use Rector\PHPUnit\ValueObject\FunctionNameWithAssertMethods; use Rector\Rector\AbstractRector; @@ -17,9 +18,10 @@ use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; /** - * @see \Rector\PHPUnit\Tests\CodeQuality\Rector\MethodCall\AssertCompareToSpecificMethodRector\AssertCompareToSpecificMethodRectorTest + * @deprecated This rule is deprecated, as its logic is handled better + * by other smaller rules in phpunit-code-quality set */ -final class AssertCompareToSpecificMethodRector extends AbstractRector +final class AssertCompareToSpecificMethodRector extends AbstractRector implements DeprecatedInterface { /** * @var string