Skip to content

Commit 81f9952

Browse files
jrpricemibrunin
authored andcommitted
[Backport] Security bug 378725734 (1/2)
Cherry-pick of patch originally reviewed on https://dawn-review.googlesource.com/c/dawn/+/215936: Validate layout constraints for all address spaces The WGSL spec has a non-normative note that the layout constraints should be validated for all non-host-shareable address spaces, using the same constraints as for storage. See linked bug for details of why this is important. Bug: 378725734 Change-Id: I3fb02506d8ded000dc3510bdc1b4a24a95089281 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/214754 Reviewed-by: David Neto <dneto@google.com> Commit-Queue: James Price <jrprice@google.com> Reviewed-by: dan sinclair <dsinclair@chromium.org> (cherry picked from commit dfa46d12ce63f131c437041d6d97a6d97c54c1b7) Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/215936 Auto-Submit: James Price <jrprice@google.com> Commit-Queue: dan sinclair <dsinclair@chromium.org> Commit-Queue: Antonio Maiorano <amaiorano@google.com> Reviewed-by: Antonio Maiorano <amaiorano@google.com> Reviewed-on: https://codereview.qt-project.org/c/qt/qtwebengine-chromium/+/611747 Reviewed-by: Anu Aliyas <anu.aliyas@qt.io>
1 parent f336b7f commit 81f9952

File tree

1 file changed

+0
-4
lines changed
  • chromium/third_party/dawn/src/tint/lang/wgsl/resolver

1 file changed

+0
-4
lines changed

chromium/third_party/dawn/src/tint/lang/wgsl/resolver/validator.cc

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -556,10 +556,6 @@ bool Validator::AddressSpaceLayout(const core::type::Type* store_ty,
556556
return true;
557557
}
558558

559-
if (!core::IsHostShareable(address_space)) {
560-
return true;
561-
}
562-
563559
auto note_usage = [&] {
564560
AddNote(source) << style::Type(store_ty->FriendlyName()) << " used in address space "
565561
<< style::Enum(address_space) << " here";

0 commit comments

Comments
 (0)