From 904464e9a688c688559a7b53fbbdbf19e5844eb4 Mon Sep 17 00:00:00 2001 From: Thomas Bouffard <27200110+tbouffard@users.noreply.github.com> Date: Mon, 3 Feb 2025 17:26:53 +0100 Subject: [PATCH 1/5] ci: modernize build.yml --- .github/workflows/build.yml | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 123dfe8..dead260 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -26,13 +26,14 @@ jobs: fail-fast: false matrix: os: - - { name: ubuntu-latest} - - { name: macos-latest } - - { name: windows-latest } + - { name: ubuntu-24.04 } + - { name: macos-14 } + - { name: windows-22 } steps: - - uses: actions/checkout@v2 - - uses: actions/setup-java@v1 + - uses: actions/checkout@v4 + - uses: actions/setup-java@v2 with: + distribution: '' java-version: 1.8 - name: build run: | From 8d865012b4283107a8effa945654b4f1d9145ee8 Mon Sep 17 00:00:00 2001 From: Thomas Bouffard <27200110+tbouffard@users.noreply.github.com> Date: Mon, 3 Feb 2025 17:28:28 +0100 Subject: [PATCH 2/5] add java distribution --- .github/workflows/build.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index dead260..37eefb2 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -33,7 +33,7 @@ jobs: - uses: actions/checkout@v4 - uses: actions/setup-java@v2 with: - distribution: '' + distribution: 'temurin' java-version: 1.8 - name: build run: | From 5988e9fedb33af83c89b3fafd87d82eefa43097e Mon Sep 17 00:00:00 2001 From: Thomas Bouffard <27200110+tbouffard@users.noreply.github.com> Date: Mon, 3 Feb 2025 17:29:09 +0100 Subject: [PATCH 3/5] update java version --- .github/workflows/build.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 37eefb2..3c4ae01 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -34,7 +34,7 @@ jobs: - uses: actions/setup-java@v2 with: distribution: 'temurin' - java-version: 1.8 + java-version: 8 - name: build run: | ./mvnw -V package From b83ac1a5b67b68f9511dd037089a3eb6d0e37e2c Mon Sep 17 00:00:00 2001 From: Thomas Bouffard <27200110+tbouffard@users.noreply.github.com> Date: Mon, 3 Feb 2025 17:33:40 +0100 Subject: [PATCH 4/5] check java 17 on ubuntu --- .github/workflows/build.yml | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 3c4ae01..ad170d0 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -20,21 +20,23 @@ on: jobs: build: - runs-on: ${{ matrix.os.name }} + runs-on: ${{ matrix.os }} strategy: # we want to run the full build on all os: don't cancel running jobs even if one fails fail-fast: false matrix: - os: - - { name: ubuntu-24.04 } - - { name: macos-14 } - - { name: windows-22 } + os: [macos-14, ubuntu-24.04, windows-2022] + java-version: [8] + include: + # Best effort: only test newest java version on Ubuntu + - os: ubuntu-24.04 + java-version: 17 steps: - uses: actions/checkout@v4 - uses: actions/setup-java@v2 with: distribution: 'temurin' - java-version: 8 + java-version: {{ matrix.java-version }} - name: build run: | ./mvnw -V package From cdbc29fbd915c99538c5a4110b624dc5aefd2686 Mon Sep 17 00:00:00 2001 From: Thomas Bouffard <27200110+tbouffard@users.noreply.github.com> Date: Mon, 3 Feb 2025 17:35:06 +0100 Subject: [PATCH 5/5] fix typo --- .github/workflows/build.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index ad170d0..07016cc 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -36,7 +36,7 @@ jobs: - uses: actions/setup-java@v2 with: distribution: 'temurin' - java-version: {{ matrix.java-version }} + java-version: ${{ matrix.java-version }} - name: build run: | ./mvnw -V package