From c1c19029fa5c4e22c87dc0a57e1e779e679fb6f0 Mon Sep 17 00:00:00 2001 From: Thomas Bouffard <27200110+tbouffard@users.noreply.github.com> Date: Mon, 3 Feb 2025 17:49:04 +0100 Subject: [PATCH 1/2] [svg2xml] Add tests to valid issue 24 (of upstream repo) --- .../java/com/mxgraph/svg2xml/Svg2XmlTest.java | 9 +++++- .../resources/svg/upstream-issue-24/entry.svg | 28 +++++++++++++++++++ 2 files changed, 36 insertions(+), 1 deletion(-) create mode 100644 src/test/resources/svg/upstream-issue-24/entry.svg diff --git a/src/test/java/com/mxgraph/svg2xml/Svg2XmlTest.java b/src/test/java/com/mxgraph/svg2xml/Svg2XmlTest.java index b85ba24..c1f5404 100644 --- a/src/test/java/com/mxgraph/svg2xml/Svg2XmlTest.java +++ b/src/test/java/com/mxgraph/svg2xml/Svg2XmlTest.java @@ -78,4 +78,11 @@ void convertToXml_files_from_two_folders_without_subfolders_files_given_ordered_ ); } -} \ No newline at end of file + @Test + void issue_upstream_24() { + Svg2Xml svg2Xml = newSvg2Xml(); + File destPath = destinationFolder("upstream_issue_24"); + svg2Xml.convertToXml(svgSourceFiles("upstream-issue-24/entry.svg"), destPath); + } + +} diff --git a/src/test/resources/svg/upstream-issue-24/entry.svg b/src/test/resources/svg/upstream-issue-24/entry.svg new file mode 100644 index 0000000..84c91dd --- /dev/null +++ b/src/test/resources/svg/upstream-issue-24/entry.svg @@ -0,0 +1,28 @@ + + + + + + + + + + + + + + + + + + + + + + + From 7dfd687e6e7eea8d7150341b4755e79999ee4500 Mon Sep 17 00:00:00 2001 From: Thomas Bouffard <27200110+tbouffard@users.noreply.github.com> Date: Mon, 3 Feb 2025 17:53:08 +0100 Subject: [PATCH 2/2] improve readme [skip ci] --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 94a4484..d1b6e7d 100644 --- a/README.md +++ b/README.md @@ -20,7 +20,7 @@ It contains the original `svg2xml` tool; it aims to improve it and to add the fo easy integration in JS programs - add [svg2js](#svg2js): convert an SVG file into a set of `mxGraph` JavaScript/TypeScript commands -**NOTE**: The main purpose of this repository is to provide the svg2js tool and to use it when developing [bpmn-visualization](https://https://github.com/process-analytics/bpmn-visualization-js). +**NOTE**: The main purpose of this repository is to provide the `svg2js` tool and to use it when developing [bpmn-visualization](https://https://github.com/process-analytics/bpmn-visualization-js). ## Build