Skip to content

Commit e53f361

Browse files
Fix the rest of the version checks
1 parent 2f777fb commit e53f361

File tree

3 files changed

+9
-9
lines changed

3 files changed

+9
-9
lines changed

docs/CHANGELOG.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
3838
tool that returns parameter schemas for any rsconnect command, allowing LLMs
3939
to more easily construct valid CLI commands.
4040

41-
- You can now deploy Holoviz Panel applications. This requires Posit Connect release 2025.11.0
41+
- You can now deploy Holoviz Panel applications. This requires Posit Connect release 2025.12.0
4242
or later. Use `rsconnect deploy panel` to deploy, or `rsconnect write-manifest panel`
4343
to create a manifest file.
4444

rsconnect/main.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -64,6 +64,7 @@
6464
RSConnectExecutor,
6565
RSConnectServer,
6666
SPCSConnectServer,
67+
server_supports_git_metadata,
6768
)
6869
from .bundle import (
6970
default_title_from_manifest,
@@ -88,6 +89,7 @@
8889
)
8990
from .environment import Environment, fake_module_file_from_directory
9091
from .exception import RSConnectException
92+
from .git_metadata import detect_git_metadata
9193
from .json_web_token import (
9294
TokenGenerator,
9395
parse_client_response,
@@ -109,8 +111,6 @@
109111
)
110112
from .shiny_express import escape_to_var_name, is_express_app
111113
from .utils_package import fix_starlette_requirements
112-
from .git_metadata import detect_git_metadata
113-
from .api import server_supports_git_metadata
114114

115115
T = TypeVar("T")
116116
P = ParamSpec("P")
@@ -368,7 +368,7 @@ def content_args(func: Callable[P, T]) -> Callable[P, T]:
368368
"Include metadata key-value pair with the bundle upload. "
369369
"Use format: key=value. May be specified multiple times. "
370370
"Use key= (empty value) to clear a detected value. "
371-
"Forces metadata upload even on older servers that don't officially support it. [v2025.11.0+]"
371+
"Forces metadata upload even on older servers that don't officially support it. [v2025.12.0+]"
372372
),
373373
)
374374
@click.option(

tests/test_git_metadata.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -132,8 +132,8 @@ def test_server_supports_git_metadata(self):
132132
assert server_supports_git_metadata("2024.01.0") is False
133133
assert server_supports_git_metadata("2025.10.0") is False
134134

135-
# Exact version - supported
136-
assert server_supports_git_metadata("2025.11.0") is True
135+
# Exact version - nope
136+
assert server_supports_git_metadata("2025.11.0") is False
137137

138138
# Newer version - supported
139139
assert server_supports_git_metadata("2025.12.0") is True
@@ -197,7 +197,7 @@ def temp_git_repo(self):
197197
def test_prepare_metadata_no_metadata_flag(self, temp_git_repo):
198198
from rsconnect.main import prepare_deploy_metadata
199199

200-
result = prepare_deploy_metadata(temp_git_repo, tuple(), True, "2025.11.0")
200+
result = prepare_deploy_metadata(temp_git_repo, tuple(), True, "2025.12.0")
201201
assert result is None
202202

203203
def test_prepare_metadata_old_server_no_cli_overrides(self, temp_git_repo):
@@ -209,7 +209,7 @@ def test_prepare_metadata_old_server_no_cli_overrides(self, temp_git_repo):
209209
def test_prepare_metadata_new_server(self, temp_git_repo):
210210
from rsconnect.main import prepare_deploy_metadata
211211

212-
result = prepare_deploy_metadata(temp_git_repo, tuple(), False, "2025.11.0")
212+
result = prepare_deploy_metadata(temp_git_repo, tuple(), False, "2025.12.0")
213213
assert result is not None
214214
assert result["source"] == "git"
215215
assert "source_commit" in result
@@ -231,7 +231,7 @@ def test_prepare_metadata_cli_clears_value(self, temp_git_repo):
231231
from rsconnect.main import prepare_deploy_metadata
232232

233233
# Empty value should clear the key
234-
result = prepare_deploy_metadata(temp_git_repo, ("source_repo=",), False, "2025.11.0")
234+
result = prepare_deploy_metadata(temp_git_repo, ("source_repo=",), False, "2.0")
235235
assert result is not None
236236
assert "source_repo" not in result # Cleared by empty value
237237
assert "source" in result # Still detected

0 commit comments

Comments
 (0)