Skip to content

Commit c045b4d

Browse files
committed
token endpoint now uses the clientauth thing, so we can safely return client_secret
1 parent e6568ff commit c045b4d

File tree

1 file changed

+1
-8
lines changed

1 file changed

+1
-8
lines changed

solid/lib/Controller/ServerController.php

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -385,14 +385,7 @@ public function register() {
385385
$clientData = $this->config->saveClientRegistration($origin, $clientData);
386386
$registration = array(
387387
'client_id' => $clientData['client_id'],
388-
/*
389-
FIXME: returning client_secret will trigger calls with basic auth to us. To get this to work, we need this patch:
390-
// File /var/www/vhosts/solid-nextcloud/site/www/lib/base.php not changed so no update needed
391-
// ($request->getRawPathInfo() !== '/apps/oauth2/api/v1/token') &&
392-
// ($request->getRawPathInfo() !== '/apps/solid/token')
393-
*/
394-
// 'client_secret' => $clientData['client_secret'], // FIXME: Returning this means we need to patch Nextcloud to accept tokens on calls to
395-
388+
'client_secret' => $clientData['client_secret'],
396389
'registration_client_uri' => $this->urlGenerator->getAbsoluteURL($this->urlGenerator->linkToRoute("solid.server.registeredClient", array("clientId" => $clientData['client_id']))),
397390
'client_id_issued_at' => $clientData['client_id_issued_at'],
398391
'redirect_uris' => $clientData['redirect_uris'],

0 commit comments

Comments
 (0)