Add support for subscribing to push notification

[xiaohuazhu]

Hi guys,

Thanks for the great work.

I'm wondering if you guys have plan to add support for subscribing to push notification. It seems to be a quick one, for instance, I tweaked the subscribe_impl and it worked. I guess we just need to overload the subscribe* methods, right?

Would it be possible to add such support? or is there a reason why push subscription was not added?

Thank you again for your great work.

[bkircher]

Hi there!

Would it be possible to add such support? or is there a reason why push subscription was not added?

Should be possible and also not too complicated.

I think it simply wasn't added yet because nobody needed it hard enough or found the time to implement. So here it is, the obligatory: Pull Requests welcome 😄

[xiaohuazhu]

Thank you for your reply. Will do when I finish my current work.

There's another question that I'm not sure if I can just mention it here to get a quick reply or I need to open a new issue. The question is that with the default cmake command line, I was able to build individual example i.e. make subscribe but when I try to make the whole project (mostly those tests, I guess) i.e. 'make', I get an error:

The error prompt does make sense to me since tests already exists as a directory. Did I miss something?

Thank you.

[bkircher]

Sean,

this just looks like you have your build directory right in the same directory where your sources are. Try to make a new build directory first, like mkdir build && cd build and execute cmake again like cmake ... This way you have no naming collisions.

[xiaohuazhu]

Worked like a charm. Thank you very much!