Array append not translate after update to version 10.0 RC

[mojtabakaviani]

In version 9.0 execute update array property work properly.

await db.LineSteps.Where(l => l.LineId == lineid)
                  .ExecuteUpdateAsync(l => l.SetProperty(p => p.Flows, p => p.Flows.Append(flowid)));

but in version 10 RC, not working. and raise error:

fail: Microsoft.AspNetCore.Diagnostics.DeveloperExceptionPageMiddleware[1]
      An unhandled exception has occurred while executing the request.
      System.InvalidOperationException: The LINQ expression 'EF.Property<short[]>(l, "Flows")
          .AsQueryable()
          .Append(@dto_FlowId)' could not be translated. Either rewrite the query in a form that can be translated, or switch to client evaluation explicitly by inserting a call to 'AsEnumerable', 'AsAsyncEnumerable', 'ToList', or 'ToListAsync'. See https://go.microsoft.com/fwlink/?linkid=2101038 for more information.

[roji]

@mojtabakaviani as always, please always submit a minimal repro rather than a single-line snippet. Your code contains db.ArrayAppend without showing what that code actually does.

In any case, I set up a repro and confirmed the regression - will look into fixing this for the next patch release.

Repro

await using var context = new BlogContext();
await context.Database.EnsureDeletedAsync();
await context.Database.EnsureCreatedAsync();

var tag = "foo";
await context.Blogs.ExecuteUpdateAsync(l => l.SetProperty(p => p.Tags, p => p.Tags.Append(tag)));

public class BlogContext : DbContext
{
    public DbSet<Blog> Blogs { get; set; }

    protected override void OnConfiguring(DbContextOptionsBuilder optionsBuilder)
        => optionsBuilder
            .UseNpgsql("Host=localhost;Username=test;Password=test")
            .LogTo(Console.WriteLine, LogLevel.Information)
            .EnableSensitiveDataLogging();
}

public class Blog
{
    public int Id { get; set; }
    public string Name { get; set; }

    public List<string> Tags { get; set; }
}

[roji]

Thanks again for reporting.

In 10, some significant improvements were made to how ExecuteUpdate works; specifically, dotnet/efcore#32493 made changes to handle ExecuteUpdate setters like other LINQ operators, doing navigation expansion.

Unfortunately, this means that setters are now treated like other known LINQ operators, as opposed to the "unknown method path" that we had before. And Append is unfortunately not supported by nav expansion (or anywhere else in EF): see dotnet/efcore#30669.

I'll do my best to take a look at this, but this is something that's too complex to fix in an EF 10.0 patch - it'll likely only be fixable for EF 11.

[mojtabakaviani]

@roji, I temporarily use DB function for append to array.