Skip to content

Commit 7ce9de1

Browse files
authored
Use 9.10.2 instead of 9.10.3 for CI on windows (#4768)
* Use 9.10.2 instead of 9.10.3 for CI on windows 9.10.2 is currently broken with TH on windows. See https://gitlab.haskell.org/ghc/ghc/-/issues/26613 * Use 9.10.2 instead of 9.10.3 for CI on windows 9.10.2 is currently broken with TH on windows. See https://gitlab.haskell.org/ghc/ghc/-/issues/26613
1 parent dcb493d commit 7ce9de1

File tree

1 file changed

+14
-6
lines changed

1 file changed

+14
-6
lines changed

.github/workflows/test.yml

Lines changed: 14 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -76,6 +76,11 @@ jobs:
7676
test:
7777
- true
7878
- false
79+
include:
80+
# 9.10.3 is broken on windows
81+
- os: windows-latest
82+
test: true
83+
ghc: "9.10.2"
7984
exclude:
8085
# Exclude the test configuration on macos, it's sufficiently similar to other OSs
8186
# that it mostly just burns CI time. Buiding is still useful since it catches
@@ -87,6 +92,9 @@ jobs:
8792
test: false
8893
- os: ubuntu-latest
8994
test: false
95+
# 9.10.3 is broken on windows
96+
- os: windows-latest
97+
ghc: "9.10"
9098

9199
steps:
92100
- uses: actions/checkout@v3
@@ -138,7 +146,7 @@ jobs:
138146
run: cabal test hls-refactor-plugin-tests || cabal test hls-refactor-plugin-tests
139147

140148
# TODO enable when it supports 9.10
141-
- if: matrix.test && matrix.ghc != '9.10' && matrix.ghc != '9.12'
149+
- if: matrix.test && matrix.ghc != '9.10' && matrix.ghc != '9.12' && matrix.ghc != '9.10.2'
142150
name: Test hls-floskell-plugin
143151
run: cabal test hls-floskell-plugin-tests || cabal test hls-floskell-plugin-tests
144152

@@ -155,7 +163,7 @@ jobs:
155163
run: cabal test hls-eval-plugin-tests || cabal test hls-eval-plugin-tests
156164

157165
# TODO enable when it supports 9.10
158-
- if: matrix.test && matrix.ghc != '9.10' && matrix.ghc != '9.12'
166+
- if: matrix.test && matrix.ghc != '9.10' && matrix.ghc != '9.12' && matrix.ghc != '9.10.2'
159167
name: Test hls-splice-plugin
160168
run: cabal test hls-splice-plugin-tests || cabal test hls-splice-plugin-tests
161169

@@ -188,7 +196,7 @@ jobs:
188196
run: cabal test hls-rename-plugin-tests || cabal test hls-rename-plugin-tests
189197

190198
# TODO enable when it supports 9.10
191-
- if: matrix.test && matrix.ghc != '9.10'
199+
- if: matrix.test && matrix.ghc != '9.10' && matrix.ghc != '9.10.2'
192200
name: Test hls-hlint-plugin test suite
193201
run: cabal test hls-hlint-plugin-tests || cabal test hls-hlint-plugin-tests
194202

@@ -225,7 +233,7 @@ jobs:
225233
run: cabal test hls-explicit-record-fields-plugin-tests || cabal test hls-explicit-record-fields-plugin-tests
226234

227235
# versions need to be limited since the tests depend on cabal-fmt which only builds with ghc <9.10
228-
- if: matrix.test && matrix.ghc != '9.10' && matrix.ghc != '9.12'
236+
- if: matrix.test && matrix.ghc != '9.10' && matrix.ghc != '9.12' && matrix.ghc != '9.10.2'
229237
name: Test hls-cabal-fmt-plugin test suite
230238
run: cabal test hls-cabal-fmt-plugin-tests --flag=isolateCabalfmtTests || cabal test hls-cabal-fmt-plugin-tests --flag=isolateCabalfmtTests
231239

@@ -238,7 +246,7 @@ jobs:
238246
run: cabal test hls-cabal-plugin-tests || cabal test hls-cabal-plugin-tests
239247

240248
# TODO enable when it supports 9.10
241-
- if: matrix.test && matrix.ghc != '9.10' && matrix.ghc != '9.12'
249+
- if: matrix.test && matrix.ghc != '9.10' && matrix.ghc != '9.12' && matrix.ghc != '9.10.2'
242250
name: Test hls-retrie-plugin test suite
243251
run: cabal test hls-retrie-plugin-tests || cabal test hls-retrie-plugin-tests
244252

@@ -256,7 +264,7 @@ jobs:
256264

257265
# The plugin tutorial is only compatible with 9.6 and 9.8.
258266
# No particular reason, just to avoid excessive CPP.
259-
- if: matrix.test && matrix.ghc != '9.4' && matrix.ghc != '9.10' && matrix.ghc != '9.12'
267+
- if: matrix.test && matrix.ghc != '9.4' && matrix.ghc != '9.10' && matrix.ghc != '9.12' && matrix.ghc != '9.10.2'
260268
name: Compile the plugin-tutorial
261269
run: cabal build plugin-tutorial
262270

0 commit comments

Comments
 (0)