Skip to content

Commit f030d19

Browse files
committed
node: Fix generator ripgrep binary mappings and add missing architectures
The @vscode/ripgrep package postinstall script expects specific binary variants for each architecture. This patch: 1. Fixes aarch64 to use musl variant instead of gnu - Both variants exist, but postinstall expects musl - Aligns with x86_64 and i386 (which also use musl) 2. Adds missing architecture mappings for ppc64, riscv64, and s390x - These architectures are supported by @vscode/ripgrep - Uses gnu variants (only available option for these arches) This causes the postinstall script to fail to find the cached binary and attempt to download from GitHub, which fails in offline build environments (RPM builds, air-gapped systems, etc). The mappings now match exactly what the postinstall script expects: https://github.com/microsoft/vscode-ripgrep/blob/main/lib/postinstall.js#L38-L47 Assisted-by: Claude Code
1 parent 3fc0620 commit f030d19

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

node/flatpak_node_generator/providers/special.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -307,7 +307,10 @@ async def get_ripgrep_tag(version: str) -> str:
307307
'x86_64': 'x86_64-unknown-linux-musl',
308308
'i386': 'i686-unknown-linux-musl',
309309
'arm': 'arm-unknown-linux-gnueabihf',
310-
'aarch64': 'aarch64-unknown-linux-gnu',
310+
'aarch64': 'aarch64-unknown-linux-musl',
311+
'ppc64': 'powerpc64le-unknown-linux-gnu',
312+
'riscv64': 'riscv64gc-unknown-linux-gnu',
313+
's390x': 's390x-unknown-linux-gnu',
311314
}
312315
destdir = self.gen.data_root / 'tmp' / f'vscode-ripgrep-cache-{package.version}'
313316
for arch, ripgrep_arch in ripgrep_arch_map.items():

0 commit comments

Comments
 (0)