tests added

Author: dkrupp

analyzer/codechecker_analyzer/analyzers/clangsa/analyzer.py

@@ -186,6 +186,14 @@ def __add_plugin_load_flags(cls, analyzer_cmd: List[str]):
         for plugin in ClangSA.analyzer_plugins():
             analyzer_cmd.extend(["-load", plugin])
 
+    @staticmethod
+    def parse_version(version_txt) -> Optional[Version]:
+        """
+        Parse the version string of the analyzer.
+        """
+        version_txt = version_txt.strip().removesuffix("git")
+        return Version.parse(version_txt)
+
     @classmethod
     def get_binary_version(cls) -> Optional[Version]:
         # No need to LOG here, we will emit a warning later anyway.
@@ -203,8 +211,7 @@ def get_binary_version(cls) -> Optional[Version]:
                                              universal_newlines=True,
                                              encoding="utf-8",
                                              errors="ignore")
-            version_txt=output.strip().removesuffix("git")
-            return Version.parse(version_txt)
+            return ClangSA.parse_version(output)
         except (subprocess.CalledProcessError, OSError) as oerr:
             LOG.warning("Failed to get analyzer version: %s",
                         ' '.join(version))

analyzer/tests/unit/test_clangsa_version_parsing.py

@@ -0,0 +1,30 @@
+# -------------------------------------------------------------------------
+#
+#  Part of the CodeChecker project, under the Apache License v2.0 with
+#  LLVM Exceptions. See LICENSE for license information.
+#  SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+#
+# -------------------------------------------------------------------------
+
+""" Test Clang version parsing. """
+
+
+from semver.version import Version
+import unittest
+
+from codechecker_analyzer.analyzers.clangsa.analyzer import ClangSA
+
+
+class ClangsaVersionTest(unittest.TestCase):
+    """
+    Test the parsing of various possible version strings, which clang
+    binaries can produce.
+    """
+
+    def test_clangsa_version(self):
+        self.assertEqual(
+            ClangSA.parse_version('18.1.3'),
+            Version(18, 1, 3))
+        self.assertEqual(
+            ClangSA.parse_version('22.0.0git'),
+            Version(22, 0, 0))