From dcbaaba7f24c92ae3aab07802268120b8e78dea5 Mon Sep 17 00:00:00 2001 From: Claudia Date: Tue, 18 Feb 2025 17:02:45 +0100 Subject: [PATCH] feat: get the deployments addresses form env vars --- script/Base.sol | 27 +++++---------------------- 1 file changed, 5 insertions(+), 22 deletions(-) diff --git a/script/Base.sol b/script/Base.sol index 191dce8..b6a11bc 100644 --- a/script/Base.sol +++ b/script/Base.sol @@ -38,36 +38,19 @@ contract BaseScript is Script, Constants { } function getRepoFactoryAddress() public view returns (address _repoFactory) { - string memory _json = _getOsxConfigs(network); - - string memory _repoFactoryKey = _buildKey(protocolVersion, PLUGIN_FACTORY_ADDRESS_KEY); + _repoFactory = vm.envAddress("PLUGIN_FACTORY_ADDRESS"); - if (!vm.keyExists(_json, _repoFactoryKey)) { - revert UnsupportedNetwork(network); - } - _repoFactory = vm.parseJsonAddress(_json, _repoFactoryKey); } function getManagementDaoAddress() public view returns (address _managementDao) { - string memory _json = _getOsxConfigs(network); - - string memory _managementDaoKey = _buildKey(protocolVersion, MANAGEMENT_DAO_ADDRESS_KEY); + _managementDao = vm.envAddress("MANAGEMENT_DAO_ADDRESS"); - if (!vm.keyExists(_json, _managementDaoKey)) { - revert UnsupportedNetwork(network); - } - _managementDao = vm.parseJsonAddress(_json, _managementDaoKey); } function getPluginRepoAddress() public view returns (address _sppRepo) { - string memory _json = _getOsxConfigs(network); - - string memory _sppRepoKey = _buildKey(protocolVersion, SPP_PLUGIN_REPO_KEY); - - if (!vm.keyExists(_json, _sppRepoKey)) { - revert UnsupportedNetwork(network); - } - _sppRepo = vm.parseJsonAddress(_json, _sppRepoKey); + // from env variable + _sppRepo = vm.envAddress("SPP_PLUGIN_REPO_ADDRESS"); + // todo: if is not set return address(0) } function getBasePluginRepoAddress() public view returns (address _sppRepo) {