Impact of changing abapGit login to HTML form

[mbtools]

The password popup is referenced in two places:

• ZABAPLINT_CONFIG
• ZABAPLINT_DEPENDENCIES

It seems the first can be removed completely:

REPORT zabaplint_config.

*TABLES sscrfields.
*INCLUDE zabapgit_password_dialog.
*INCLUDE zabapgit_forms.
*INITIALIZATION.
*  lcl_password_dialog=>on_screen_init( ).
*AT SELECTION-SCREEN OUTPUT.
*  IF sy-dynnr = lcl_password_dialog=>c_dynnr.
*    lcl_password_dialog=>on_screen_output( ).
*  ENDIF.
*AT SELECTION-SCREEN.
*  IF sy-dynnr = lcl_password_dialog=>c_dynnr.
*    lcl_password_dialog=>on_screen_event( sscrfields-ucomm ).
*  ENDIF.

START-OF-SELECTION.
  CALL FUNCTION 'Z_ABAPLINT_CONFIGURATION'.

However, the second case is tricky. In ZABAPLINT_DEPENDENCIES there is no HTML GUI involved and therefore the raise_login exception won't be redirected to the HTML form. I think this requires a bit of a rewrite to capture the login details (user/password) upfront, set them in the login manager, and then run the dependency check (zcl_abaplint_deps_git->run). Hmm...

[fabianlupa]

The current approach doesn't seem to work either for me.

When clicking on "Update from abapGit":

sy-cprog is SAPLS_CODE_INSPECTOR in this case....

[larshp]

nope, it doesnt work right now

to solve this the login must be decoupled from the UI in abapGit