Uma Voting CLI: More testing on mainnet/testnets and Metamask Provider

[nicholaspai]

Currently it works well and has been tested on localhost using provided web3 accounts, seems to break on Metamask when signing transactions

Reading from mainnet seems to work, but have not verified writing to mainnet

[nicholaspai]

@mrice32 @chrismaree

For example,

CLI currently breaks on mainnet because it cannot call() Voting.rounds(roundID) because the currently deployed contract does not have a public array rounds which we added in in #832 .

[nicholaspai]

MetaMask connectivity bugs:

• Handling Big Numbers:
  • The node-metamask npm package has one file RemoteMetaMaskProvider.js which I believe overwrites all of the web3 send calls. Basically every single web3 query or sendTransaction goes through this method, however this method as implemented fails in certain situations. For example, a call to web3.eth.getBalance(address) fails if the account has more than 1e21 ETH. This is very possible in a testing environment. This is because the method at some point fails to convert from the scientific notation of the number back into a string. This causes a bignumber error because you cannot pass in scientific notation into a big number.
• Events: Metamask is having problems reading some events such as "PriceResolved" or "VoteRevealed" making retrieving rewards error-prone. Sometimes I've been able to read "VoteRevealed" events via web3.contract.getPastEvents but never have been able to read "PriceResolved". Perhaps related to this

[nicholaspai]

Forked node-metamask and attempted to resolve the first issue in our forked repo

PR to node-metamask