feat: remove fetchFavoriteComponents method

Author: maxy-shpfy

src/providers/ComponentLibraryProvider/ComponentLibraryProvider.test.tsx

@@ -56,9 +56,6 @@ const mockFetchUserComponents = vi.mocked(
 const mockFetchUsedComponents = vi.mocked(
   componentLibraryUtils.fetchUsedComponents,
 );
-const mockFetchFavoriteComponents = vi.mocked(
-  componentLibraryUtils.fetchFavoriteComponents,
-);
 const mockPopulateComponentRefs = vi.mocked(
   componentLibraryUtils.populateComponentRefs,
 );
@@ -149,11 +146,6 @@ describe("ComponentLibraryProvider - Component Management", () => {
       components: [],
       folders: [],
     });
-    mockFetchFavoriteComponents.mockReturnValue({
-      name: "Favorites",
-      components: [],
-      folders: [],
-    });
     mockPopulateComponentRefs.mockImplementation((lib) => Promise.resolve(lib));
     mockFlattenFolders.mockImplementation((folder) => {
       if ("folders" in folder) {

src/providers/ComponentLibraryProvider/componentLibrary.test.ts

@@ -16,7 +16,6 @@ import * as localforage from "@/utils/localforage";
 import * as yamlUtils from "@/utils/yaml";
 
 import {
-  fetchFavoriteComponents,
   fetchUsedComponents,
   fetchUserComponents,
   filterToUniqueByDigest,
@@ -261,89 +260,6 @@ describe("componentLibrary", () => {
     // todo: test with deeply nested task structures
   });
 
-  describe("fetchFavoriteComponents", () => {
-    const mockComponentLibrary: ComponentLibrary = {
-      folders: [
-        {
-          name: "Folder 1",
-          components: [
-            {
-              name: "component-1",
-              digest: "digest1",
-              favorited: true,
-            },
-            {
-              name: "component-2",
-              digest: "digest2",
-              favorited: false,
-            },
-          ],
-          folders: [
-            {
-              name: "Subfolder",
-              components: [
-                {
-                  name: "component-3",
-                  digest: "digest3",
-                  favorited: true,
-                },
-              ],
-              folders: [],
-            },
-          ],
-        },
-      ],
-    };
-
-    it("should return favorited components from library", () => {
-      // Act
-      const result = fetchFavoriteComponents(mockComponentLibrary);
-
-      // Assert
-      expect(result).toEqual({
-        name: "Favorite Components",
-        components: [
-          {
-            name: "component-1",
-            digest: "digest1",
-            favorited: true,
-          },
-          {
-            name: "component-3",
-            digest: "digest3",
-            favorited: true,
-          },
-        ],
-        folders: [],
-        isUserFolder: false,
-      });
-    });
-
-    it("should return empty folder when no component library provided", () => {
-      // Act
-      const result = fetchFavoriteComponents(undefined);
-
-      // Assert
-      expect(result).toEqual({
-        name: "Favorite Components",
-        components: [],
-        folders: [],
-        isUserFolder: false,
-      });
-    });
-
-    it("should work without user components", () => {
-      // Act
-      const result = fetchFavoriteComponents(mockComponentLibrary);
-
-      // Assert
-      expect(result.components).toHaveLength(2);
-      expect(result.components?.every((c) => c.favorited)).toBe(true);
-    });
-
-    // todo: test deduplication of favorites with same digest across library and user components
-  });
-
   describe("populateComponentRefs", () => {
     beforeEach(() => {
       mockComponentService.parseComponentData.mockImplementation(

src/providers/ComponentLibraryProvider/componentLibrary.ts

@@ -89,36 +89,6 @@ export async function isFavoriteComponent(component: ComponentReference) {
   );
 }
 
-/**
- * @deprecated
- */
-export const fetchFavoriteComponents = (
-  componentLibrary: ComponentLibrary | undefined,
-): ComponentFolder => {
-  const favoritesFolder = {
-    name: "Favorite Components",
-    components: [] as ComponentReference[],
-    folders: [],
-    isUserFolder: false,
-  };
-
-  if (!componentLibrary || !componentLibrary.folders) {
-    return favoritesFolder;
-  }
-
-  const uniqueLibraryComponents = filterToUniqueByDigest(
-    flattenFolders(componentLibrary),
-  );
-
-  uniqueLibraryComponents.forEach((component) => {
-    if (component?.favorited) {
-      favoritesFolder.components.push(component);
-    }
-  });
-
-  return favoritesFolder;
-};
-
 export async function populateComponentRefs<
   T extends ComponentLibrary | ComponentFolder,
 >(libraryOrFolder: T): Promise<T> {