Wrong format of urlencoded list

[lotooo]

Describe the bug

When using this library trying to update an existing check, I receive a 400 because some fields use the wrong format.

The 2 specific fields I tested that a reporting bad format are tags and 'contact_groups.

To Reproduce
Steps to reproduce the behavior:

1. Call update_uptime_test with a list as tags or contact_groups
2. You receive a 400

Expected behavior

It works and respect the docs in https://www.statuscake.com/api/v1/#tag/uptime/operation/update-uptime-test

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

• OS: [e.g. iOS]
• Browser [e.g. chrome, safari]
• Version [e.g. 22]

Smartphone (please complete the following information):

• Device: [e.g. iPhone6]
• OS: [e.g. iOS8.1]
• Browser [e.g. stock browser, safari]
• Version [e.g. 22]

Additional context

I enabled urllib debug level and it seems the generated URL is using contact_groups=111111&contact_groups=111112 instead of contact_groups[]=111111&contact_groups[]=111112, not sure it's a SDK/library problem, I did a workaround using requests and I had to rename the attributes to make them work.

[tomasbasham]

Thank you for the report. This is helpful for improving the package. Since this package is in the alpha phase we'd advise that it not be used in production scenarios as there are still issues, as you've demonstrated. At present we have no clear timeline as to when this issue will be fixed. Hopefully in the near future

[kkerce]

+1

Especially since https://www.statuscake.com/api/ indicates the existing API will be deprecated today:

[kkerce]

@tomasbasham Can this issue be addressed soon? It's a major blocker if uptime tests with contact groups can't be created via this SDK.

[joachimtingvold]

Since the API doesn't support JSON payload either (which would be way easier via r.post(url,json=data,headers=headers)), you have to use the old method with "list of tuples" as input data to requests. Quick excerpt shown below (if you have all the required API parameters in a dict);

def dict_to_tuple_list(d):
  tuple_list = []
  for key in d:
    if type(d[key]) is list:
      for item in d[key]:
        tuple_list.append( (key + '[]', item) )
    else:
      tuple_list.append( (key, d[key]) )
  return tuple_list

headers = {
  "Authorization": f"Bearer { api_key }"
}
tuple_data = dict_to_tuple_list(some_dict)
requests.post(f"{api_url}/{endpoint}", data=tuple_data, headers=headers)

[bobbythebus]

@tomasbasham any updates on this?