From 385db772dbda01db7e55cad48e514701c0835985 Mon Sep 17 00:00:00 2001 From: Roderick van Domburg Date: Sun, 13 Jul 2025 22:17:03 +0200 Subject: [PATCH 1/3] fix(clippy): deprecated attribute must contain minor version --- CHANGELOG.md | 3 +++ src/source/noise.rs | 4 ++-- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index f5f6e58e..33883c15 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -13,6 +13,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 - Upgrade `cpal` to v0.16. - Update dependencies. +### Fixed +- Fix clippy warnings with `Source::white` and `Source::pink` functions. + ## Version [0.21] (2025-07-12) ### Added diff --git a/src/source/noise.rs b/src/source/noise.rs index 357a2cf6..ec812f43 100644 --- a/src/source/noise.rs +++ b/src/source/noise.rs @@ -41,13 +41,13 @@ use rand_distr::{Normal, Triangular}; use crate::{ChannelCount, Sample, SampleRate, Source}; /// Convenience function to create a new `WhiteUniform` noise source. -#[deprecated(since = "0.21", note = "use WhiteUniform::new() instead")] +#[deprecated(since = "0.21.0", note = "use WhiteUniform::new() instead")] pub fn white(sample_rate: SampleRate) -> WhiteUniform { WhiteUniform::new(sample_rate) } /// Convenience function to create a new `Pink` noise source. -#[deprecated(since = "0.21", note = "use Pink::new() instead")] +#[deprecated(since = "0.21.0", note = "use Pink::new() instead")] pub fn pink(sample_rate: SampleRate) -> Pink { Pink::new(sample_rate) } From b66b87a305d947ffc535a302a98d7789e061e0b5 Mon Sep 17 00:00:00 2001 From: Roderick van Domburg Date: Sun, 13 Jul 2025 22:18:52 +0200 Subject: [PATCH 2/3] ci: run clippy with all features --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index a4284f6c..77b85f24 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -35,7 +35,7 @@ jobs: - name: install ${{ matrix.toolchain }} toolchain run: rustup toolchain install ${{ matrix.toolchain }} && rustup default ${{ matrix.toolchain }} - - run: cargo clippy -- -D warnings + - run: cargo clippy --all-features -- -D warnings if: matrix.toolchain == 'stable' && matrix.os == 'ubuntu-latest' - run: | From 741611c4730acbb0f76145ae05d9c37f549835e4 Mon Sep 17 00:00:00 2001 From: Roderick van Domburg Date: Sun, 13 Jul 2025 22:23:35 +0200 Subject: [PATCH 3/3] docs: fix Markdown link syntax in UPGRADE.md --- UPGRADE.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/UPGRADE.md b/UPGRADE.md index 1d58f6d2..887dce1d 100644 --- a/UPGRADE.md +++ b/UPGRADE.md @@ -3,7 +3,7 @@ rodio. While we did our best, we might have missed things. PRs that improve this guide are very welcome! The list below only contains required code changes. For a complete list of -changes and new features, see [CHANGELOG.md]. +changes and new features, see [CHANGELOG.md](CHANGELOG.md). # rodio 0.21 to current GitHub version