Skip to content

Commit ceb4880

Browse files
committed
some improvements
1 parent 26ee0c4 commit ceb4880

File tree

2 files changed

+15
-7
lines changed

2 files changed

+15
-7
lines changed

src/redturtle/rsync/adapters/adapter.py

Lines changed: 13 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -179,6 +179,10 @@ def set_args(self, parser):
179179
"""
180180
return
181181

182+
def setup_environment(self):
183+
""" """
184+
return
185+
182186
def get_data(self):
183187
""" """
184188
try:
@@ -212,6 +216,13 @@ def find_item_from_row(self, row):
212216
self.log_info(msg=msg, type="error")
213217
return None
214218

219+
def create_or_update_item(self, row):
220+
item = self.find_item_from_row(row=row)
221+
if not item:
222+
self.create_item(row=row)
223+
else:
224+
self.update_item(item=item, row=row)
225+
215226
def create_item(self, row):
216227
"""
217228
Create the item.
@@ -223,8 +234,8 @@ def create_item(self, row):
223234
self.log_info(msg=msg, type="error")
224235
return
225236
if not res:
226-
msg = f"[Error] item {row} not created."
227-
self.log_info(msg=msg, type="error")
237+
msg = f"[SKIPPED] item {row} not created."
238+
self.log_info(msg=msg)
228239
return
229240

230241
# adapter could create a list of items (maybe also children or related items)

src/redturtle/rsync/scripts/rsync.py

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -68,6 +68,7 @@ def rsync(self):
6868
"""
6969
start = datetime.now()
7070
logger.info(f"[{start}] - START RSYNC")
71+
self.adapter.setup_environment()
7172
data = self.adapter.get_data()
7273
if data:
7374
n_items = len(data)
@@ -80,11 +81,7 @@ def rsync(self):
8081
if i % 100 == 0:
8182
logger.info(f"Progress: {i}/{n_items}")
8283

83-
item = self.adapter.find_item_from_row(row=row)
84-
if not item:
85-
self.adapter.create_item(row=row)
86-
else:
87-
self.adapter.update_item(item=item, row=row)
84+
self.adapter.create_or_update_item(row=row)
8885

8986
self.adapter.delete_items(data)
9087

0 commit comments

Comments
 (0)