fix unreachable_pub for orchestrator (#614)

Author: noot

crates/orchestrator/Cargo.toml

@@ -3,6 +3,9 @@ name = "orchestrator"
 version.workspace = true
 edition.workspace = true
 
+[lints]
+workspace = true
+
 [dependencies]
 actix-web = { workspace = true }
 actix-web-prometheus = "0.1.2"
@@ -35,4 +38,4 @@ iroh = { workspace = true }
 rand_v8 = { workspace = true }
 
 [dev-dependencies]
-mockito = { workspace = true }
+mockito = { workspace = true }

crates/orchestrator/src/api/mod.rs

@@ -1,3 +1,3 @@
-pub mod routes;
-pub mod server;
-pub mod tests;
+pub(crate) mod routes;
+pub(crate) mod server;
+pub(crate) mod tests;

crates/orchestrator/src/api/routes/groups.rs

@@ -371,7 +371,7 @@ async fn force_regroup(
     }
 }
 
-pub fn groups_routes() -> Scope {
+pub(crate) fn groups_routes() -> Scope {
     web::scope("/groups")
         .route("", get().to(get_groups))
         .route("/configs", get().to(get_configurations))

crates/orchestrator/src/api/routes/heartbeat.rs

@@ -172,7 +172,7 @@ async fn heartbeat(
     }
 }
 
-pub fn heartbeat_routes() -> Scope {
+pub(crate) fn heartbeat_routes() -> Scope {
     web::scope("/heartbeat").route("", post().to(heartbeat))
 }
 

crates/orchestrator/src/api/routes/metrics.rs

@@ -153,7 +153,7 @@ async fn delete_metric(
     }))
 }
 
-pub fn metrics_routes() -> Scope {
+pub(crate) fn metrics_routes() -> Scope {
     web::scope("/metrics")
         .route("", get().to(get_metrics))
         .route("/all", get().to(get_all_metrics))

crates/orchestrator/src/api/routes/mod.rs

@@ -1,6 +1,6 @@
-pub mod groups;
-pub mod heartbeat;
-pub mod metrics;
-pub mod nodes;
-pub mod storage;
-pub mod task;
+pub(crate) mod groups;
+pub(crate) mod heartbeat;
+pub(crate) mod metrics;
+pub(crate) mod nodes;
+pub(crate) mod storage;
+pub(crate) mod task;

crates/orchestrator/src/api/routes/nodes.rs

@@ -392,7 +392,7 @@ async fn ban_node(node_id: web::Path<String>, app_state: Data<AppState>) -> Http
     }
 }
 
-pub fn nodes_routes() -> Scope {
+pub(crate) fn nodes_routes() -> Scope {
     web::scope("/nodes")
         .route("", get().to(get_nodes))
         .route("/{node_id}/restart", post().to(restart_node_task))

crates/orchestrator/src/api/routes/storage.rs

@@ -308,7 +308,7 @@ async fn request_upload(
     }
 }
 
-pub fn storage_routes() -> Scope {
+pub(crate) fn storage_routes() -> Scope {
     web::scope("/storage").route("/request-upload", post().to(request_upload))
 }
 

crates/orchestrator/src/api/routes/task.rs

@@ -124,7 +124,7 @@ async fn delete_all_tasks(app_state: Data<AppState>) -> HttpResponse {
     HttpResponse::Ok().json(json!({"success": true}))
 }
 
-pub fn tasks_routes() -> Scope {
+pub(crate) fn tasks_routes() -> Scope {
     web::scope("/tasks")
         .route("", get().to(get_all_tasks))
         .route("", post().to(create_task))

crates/orchestrator/src/api/server.rs

@@ -115,7 +115,7 @@ async fn health_check(data: web::Data<AppState>) -> HttpResponse {
     }
 }
 
-pub struct AppState {
+pub(crate) struct AppState {
     pub store_context: Arc<StoreContext>,
     pub storage_provider: Option<Arc<dyn StorageProvider>>,
     pub heartbeats: Arc<LoopHeartbeats>,