From 8759dbc5a4496a2c5c1e3557edf83edc9c1d963e Mon Sep 17 00:00:00 2001 From: Tom Rindell Date: Tue, 6 Jan 2026 00:06:44 +0200 Subject: [PATCH 1/2] Update 01_Image_view_and_sampler.adoc Removed some fields which appear early but are introduced only later in the text. --- en/06_Texture_mapping/01_Image_view_and_sampler.adoc | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/en/06_Texture_mapping/01_Image_view_and_sampler.adoc b/en/06_Texture_mapping/01_Image_view_and_sampler.adoc index bc419161..1a4b1015 100644 --- a/en/06_Texture_mapping/01_Image_view_and_sampler.adoc +++ b/en/06_Texture_mapping/01_Image_view_and_sampler.adoc @@ -144,8 +144,8 @@ The choices are `VK_FILTER_NEAREST` and `VK_FILTER_LINEAR`, corresponding to the [,c++] ---- -vk::SamplerCreateInfo samplerInfo{.magFilter = vk::Filter::eLinear, .minFilter = vk::Filter::eLinear, .mipmapMode = vk::SamplerMipmapMode::eLinear, - .addressModeU = vk::SamplerAddressMode::eRepeat, .addressModeV = vk::SamplerAddressMode::eRepeat }; +vk::SamplerCreateInfo samplerInfo{.magFilter = vk::Filter::eLinear, .minFilter = vk::Filter::eLinear, + .addressModeU = vk::SamplerAddressMode::eRepeat, .addressModeV = vk::SamplerAddressMode::eRepeat, .addressModeW = vk::SamplerAddressMode::eRepeat}; ---- The addressing mode can be specified per axis using the `addressMode` fields. @@ -166,7 +166,7 @@ However, the repeat mode is probably the most common mode, because it can be use [,c++] ---- vk::PhysicalDeviceProperties properties = physicalDevice.getProperties(); -vk::SamplerCreateInfo samplerInfo{.magFilter = vk::Filter::eLinear, .minFilter = vk::Filter::eLinear, .mipmapMode = vk::SamplerMipmapMode::eLinear, +vk::SamplerCreateInfo samplerInfo{.magFilter = vk::Filter::eLinear, .minFilter = vk::Filter::eLinear, .addressModeU = vk::SamplerAddressMode::eRepeat, .addressModeV = vk::SamplerAddressMode::eRepeat, .addressModeW = vk::SamplerAddressMode::eRepeat, .anisotropyEnable = vk::True, .maxAnisotropy = properties.limits.maxSamplerAnisotropy}; ---- @@ -189,10 +189,9 @@ If we want to go for maximum quality, we can simply use that value directly: [,c++] ---- vk::PhysicalDeviceProperties properties = physicalDevice.getProperties(); -vk::SamplerCreateInfo samplerInfo{.magFilter = vk::Filter::eLinear, .minFilter = vk::Filter::eLinear, .mipmapMode = vk::SamplerMipmapMode::eLinear, +vk::SamplerCreateInfo samplerInfo{.magFilter = vk::Filter::eLinear, .minFilter = vk::Filter::eLinear, .addressModeU = vk::SamplerAddressMode::eRepeat, .addressModeV = vk::SamplerAddressMode::eRepeat, .addressModeW = vk::SamplerAddressMode::eRepeat, - .anisotropyEnable = vk::True, .maxAnisotropy = properties.limits.maxSamplerAnisotropy, - .compareEnable = vk::False, .compareOp = vk::CompareOp::eAlways}; + .anisotropyEnable = vk::True, .maxAnisotropy = properties.limits.maxSamplerAnisotropy}; ---- You can either query the properties at the beginning of your program and pass them around to the functions that need them, or query them in the `createTextureSampler` function itself. From 88b68740718ec483646b96b40969b57f941ec4e9 Mon Sep 17 00:00:00 2001 From: Tom Rindell Date: Sat, 10 Jan 2026 10:08:33 +0200 Subject: [PATCH 2/2] Update 01_Image_view_and_sampler.adoc Removed .addressModeW flags --- en/06_Texture_mapping/01_Image_view_and_sampler.adoc | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/en/06_Texture_mapping/01_Image_view_and_sampler.adoc b/en/06_Texture_mapping/01_Image_view_and_sampler.adoc index 1a4b1015..8ce59e97 100644 --- a/en/06_Texture_mapping/01_Image_view_and_sampler.adoc +++ b/en/06_Texture_mapping/01_Image_view_and_sampler.adoc @@ -145,7 +145,7 @@ The choices are `VK_FILTER_NEAREST` and `VK_FILTER_LINEAR`, corresponding to the [,c++] ---- vk::SamplerCreateInfo samplerInfo{.magFilter = vk::Filter::eLinear, .minFilter = vk::Filter::eLinear, - .addressModeU = vk::SamplerAddressMode::eRepeat, .addressModeV = vk::SamplerAddressMode::eRepeat, .addressModeW = vk::SamplerAddressMode::eRepeat}; + .addressModeU = vk::SamplerAddressMode::eRepeat, .addressModeV = vk::SamplerAddressMode::eRepeat}; ---- The addressing mode can be specified per axis using the `addressMode` fields. @@ -167,7 +167,7 @@ However, the repeat mode is probably the most common mode, because it can be use ---- vk::PhysicalDeviceProperties properties = physicalDevice.getProperties(); vk::SamplerCreateInfo samplerInfo{.magFilter = vk::Filter::eLinear, .minFilter = vk::Filter::eLinear, - .addressModeU = vk::SamplerAddressMode::eRepeat, .addressModeV = vk::SamplerAddressMode::eRepeat, .addressModeW = vk::SamplerAddressMode::eRepeat, + .addressModeU = vk::SamplerAddressMode::eRepeat, .addressModeV = vk::SamplerAddressMode::eRepeat, .anisotropyEnable = vk::True, .maxAnisotropy = properties.limits.maxSamplerAnisotropy}; ---- @@ -190,7 +190,7 @@ If we want to go for maximum quality, we can simply use that value directly: ---- vk::PhysicalDeviceProperties properties = physicalDevice.getProperties(); vk::SamplerCreateInfo samplerInfo{.magFilter = vk::Filter::eLinear, .minFilter = vk::Filter::eLinear, - .addressModeU = vk::SamplerAddressMode::eRepeat, .addressModeV = vk::SamplerAddressMode::eRepeat, .addressModeW = vk::SamplerAddressMode::eRepeat, + .addressModeU = vk::SamplerAddressMode::eRepeat, .addressModeV = vk::SamplerAddressMode::eRepeat, .anisotropyEnable = vk::True, .maxAnisotropy = properties.limits.maxSamplerAnisotropy}; ----