From 64cd5669f2f5b83aa2d0f65e94538fd1f49dda78 Mon Sep 17 00:00:00 2001 From: Garvit Singla Date: Wed, 31 Dec 2025 11:48:39 +0530 Subject: [PATCH 1/3] Fixing alpha multiplication for Table in MultiplyAlpha trait --- node-graph/nodes/blending/src/lib.rs | 1 + 1 file changed, 1 insertion(+) diff --git a/node-graph/nodes/blending/src/lib.rs b/node-graph/nodes/blending/src/lib.rs index 6c07eb5490..6cb6d6d4f7 100644 --- a/node-graph/nodes/blending/src/lib.rs +++ b/node-graph/nodes/blending/src/lib.rs @@ -39,6 +39,7 @@ impl MultiplyAlpha for Table> { impl MultiplyAlpha for Table { fn multiply_alpha(&mut self, factor: f64) { for row in self.iter_mut() { + *row.element = row.element.multiplied_alpha(factor as f32); row.alpha_blending.opacity *= factor as f32; } } From 5b7ff3a1c78608d670800b81131f4bc648191c16 Mon Sep 17 00:00:00 2001 From: Garvit Singla Date: Wed, 31 Dec 2025 11:54:06 +0530 Subject: [PATCH 2/3] Fixing alpha multiplication for Table in MultiplyAlpha trait --- node-graph/nodes/blending/src/lib.rs | 1 + 1 file changed, 1 insertion(+) diff --git a/node-graph/nodes/blending/src/lib.rs b/node-graph/nodes/blending/src/lib.rs index 6cb6d6d4f7..a5ea35dd29 100644 --- a/node-graph/nodes/blending/src/lib.rs +++ b/node-graph/nodes/blending/src/lib.rs @@ -1,3 +1,4 @@ +use core_types::color::Alpha; use core_types::registry::types::Percentage; use core_types::table::Table; use core_types::{BlendMode, Color, Ctx}; From 76b9ceffc7bf98a75715b6429c41b595759050d3 Mon Sep 17 00:00:00 2001 From: Garvit Singla Date: Wed, 31 Dec 2025 12:15:17 +0530 Subject: [PATCH 3/3] Fix/multiple alpha for table color --- node-graph/nodes/blending/src/lib.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/node-graph/nodes/blending/src/lib.rs b/node-graph/nodes/blending/src/lib.rs index a5ea35dd29..8cdbce98b8 100644 --- a/node-graph/nodes/blending/src/lib.rs +++ b/node-graph/nodes/blending/src/lib.rs @@ -1,4 +1,4 @@ -use core_types::color::Alpha; +use core_types::color::{AlphaMut}; use core_types::registry::types::Percentage; use core_types::table::Table; use core_types::{BlendMode, Color, Ctx}; @@ -40,7 +40,7 @@ impl MultiplyAlpha for Table> { impl MultiplyAlpha for Table { fn multiply_alpha(&mut self, factor: f64) { for row in self.iter_mut() { - *row.element = row.element.multiplied_alpha(factor as f32); + row.element.set_alpha(factor as f32); row.alpha_blending.opacity *= factor as f32; } }