nc_realloc frees the ptr upon realloc failure which is causing application crash

[CoolPreet]

Hello libnetconf team,
We are seeing a application crash after calling the nc_recv_reply. The crash is causing on below path,
nc_recv_reply -> recv_msg -> nc_read_msg_io -> CRASH
Please find the attached analysis document for more details.

CRASH_ANALYSIS_Report.md

[michalvasko]

Fine, I have added some basic checks. But despite your detailed report, I could find no program path that would result in a crash. What libnetconf2 version are you using? Do you have your own server or are using netopeer2-server?

[CoolPreet]

We are using libnetconf2 v2.1.25 and netopeer2 server v2.1.42.

[michalvasko]

That is really old so my suggestion is to update the projects to recent versions.