Skip to content

Commit 0113844

Browse files
author
Tan Le
committed
Drop support for Ruby 2.3 and 2.4
With Ruby 2.3 and 2.4 being EOL, we should move our support accordingly to keep pace with maitaintenance effort. This also allows simpler interporability with dependent gems (i.e. `nokogiri`).
1 parent 05ea58a commit 0113844

File tree

8 files changed

+16
-42
lines changed

8 files changed

+16
-42
lines changed

.rubocop.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
AllCops:
2-
TargetRubyVersion: 1.9.3
2+
TargetRubyVersion: 2.5.0
33
# Turns off the default Rubocop rules.
44
DisabledByDefault: true
55
Exclude:

.travis.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,6 @@
22
language: ruby
33

44
rvm:
5-
- 2.3.0
6-
- 2.4.1
75
- 2.5.0
86
- 2.6.0
97

Gemfile

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -27,11 +27,7 @@ source "https://rubygems.org" do
2727
gem "faraday", "~> 1.0", :require => false
2828
gem "faraday_middleware", "~> 1.0.0.rc1", :require => false
2929
gem "net-http-persistent", "~> 4.0", :require => false
30-
if RUBY_VERSION.start_with?("2.3") then
31-
gem "nokogiri", "~> 1.10.4", :require => false
32-
else
33-
gem "nokogiri", "~> 1.11.0.rc2", :require => false
34-
end
30+
gem "nokogiri", "~> 1.11.1", :require => false
3531

3632
gem "adal", "~> 1.0", :require => false
3733
gem "dotenv", "~> 2.0", :require => false

blob/azure-storage-blob.gemspec

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -38,14 +38,10 @@ Gem::Specification.new do |s|
3838
s.license = "MIT"
3939
s.files = `git ls-files ./lib/azure/storage/blob/`.split("\n") << "./lib/azure/storage/blob.rb"
4040

41-
s.required_ruby_version = ">= 2.3.0"
41+
s.required_ruby_version = ">= 2.5.0"
4242

4343
s.add_runtime_dependency("azure-storage-common", "~> 2.0")
44-
if RUBY_VERSION < "2.4.0"
45-
s.add_runtime_dependency("nokogiri", "~> 1.10.4")
46-
else
47-
s.add_runtime_dependency("nokogiri", "~> 1.11.0.rc2")
48-
end
44+
s.add_runtime_dependency("nokogiri", "~> 1.11.1")
4945

5046
s.add_development_dependency("dotenv", "~> 2.0")
5147
s.add_development_dependency("minitest", "~> 5")

common/azure-storage-common.gemspec

Lines changed: 6 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -39,16 +39,12 @@ Gem::Specification.new do |s|
3939
s.files = `git ls-files ./lib/azure/storage/common/`.split("\n") << "./lib/azure/storage/common.rb"
4040
s.files += `git ls-files ./lib/azure/core/`.split("\n") << "./lib/azure/core.rb" << "./lib/azure/http_response_helper.rb"
4141

42-
s.required_ruby_version = ">= 2.3.0"
42+
s.required_ruby_version = ">= 2.5.0"
4343

44-
s.add_runtime_dependency('faraday', '~> 1.0')
45-
s.add_runtime_dependency('faraday_middleware', '~> 1.0.0.rc1')
46-
s.add_runtime_dependency("net-http-persistent", '~> 4.0')
47-
if RUBY_VERSION < "2.4.0"
48-
s.add_runtime_dependency("nokogiri", "~> 1.10.4")
49-
else
50-
s.add_runtime_dependency("nokogiri", "~> 1.11.0.rc2")
51-
end
44+
s.add_runtime_dependency("faraday", "~> 1.0")
45+
s.add_runtime_dependency("faraday_middleware", "~> 1.0.0.rc1")
46+
s.add_runtime_dependency("net-http-persistent", "~> 4.0")
47+
s.add_runtime_dependency("nokogiri", "~> 1.11.1")
5248

5349
s.add_development_dependency("dotenv", "~> 2.0")
5450
s.add_development_dependency("minitest", "~> 5")
@@ -57,5 +53,5 @@ Gem::Specification.new do |s|
5753
s.add_development_dependency("rake", "~> 13.0")
5854
s.add_development_dependency("timecop", "~> 0.7")
5955
s.add_development_dependency("yard", "~> 0.9", ">= 0.9.11")
60-
s.add_development_dependency('bundler', '~> 1.11')
56+
s.add_development_dependency("bundler", "~> 1.11")
6157
end

file/azure-storage-file.gemspec

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -38,14 +38,10 @@ Gem::Specification.new do |s|
3838
s.license = "MIT"
3939
s.files = `git ls-files ./lib/azure/storage/file`.split("\n") << "./lib/azure/storage/file.rb"
4040

41-
s.required_ruby_version = ">= 2.3.0"
41+
s.required_ruby_version = ">= 2.5.0"
4242

4343
s.add_runtime_dependency("azure-storage-common", "~> 2.0")
44-
if RUBY_VERSION < "2.4.0"
45-
s.add_runtime_dependency("nokogiri", "~> 1.10.4")
46-
else
47-
s.add_runtime_dependency("nokogiri", "~> 1.11.0.rc2")
48-
end
44+
s.add_runtime_dependency("nokogiri", "~> 1.11.1")
4945

5046
s.add_development_dependency("dotenv", "~> 2.0")
5147
s.add_development_dependency("minitest", "~> 5")

queue/azure-storage-queue.gemspec

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -38,14 +38,10 @@ Gem::Specification.new do |s|
3838
s.license = "MIT"
3939
s.files = `git ls-files ./lib/azure/storage/queue/`.split("\n") << "./lib/azure/storage/queue.rb"
4040

41-
s.required_ruby_version = ">= 2.3.0"
41+
s.required_ruby_version = ">= 2.5.0"
4242

4343
s.add_runtime_dependency("azure-storage-common", "~> 2.0")
44-
if RUBY_VERSION < "2.4.0"
45-
s.add_runtime_dependency("nokogiri", "~> 1.10.4")
46-
else
47-
s.add_runtime_dependency("nokogiri", "~> 1.11.0.rc2")
48-
end
44+
s.add_runtime_dependency("nokogiri", "~> 1.11.1")
4945

5046
s.add_development_dependency("dotenv", "~> 2.0")
5147
s.add_development_dependency("minitest", "~> 5")

table/azure-storage-table.gemspec

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -38,14 +38,10 @@ Gem::Specification.new do |s|
3838
s.license = "MIT"
3939
s.files = `git ls-files ./lib/azure/storage/table/`.split("\n") << "./lib/azure/storage/table.rb"
4040

41-
s.required_ruby_version = ">= 2.3.0"
41+
s.required_ruby_version = ">= 2.5.0"
4242

4343
s.add_runtime_dependency("azure-storage-common", "~> 2.0")
44-
if RUBY_VERSION < "2.4.0"
45-
s.add_runtime_dependency("nokogiri", "~> 1.10.4")
46-
else
47-
s.add_runtime_dependency("nokogiri", "~> 1.11.0.rc2")
48-
end
44+
s.add_runtime_dependency("nokogiri", "~> 1.11.1")
4945

5046
s.add_development_dependency("dotenv", "~> 2.0")
5147
s.add_development_dependency("minitest", "~> 5")

0 commit comments

Comments
 (0)